Re: [libvirt] [PATCH v2] python: Fix bindings for virDomainSnapshotGet{Domain, Connect}

On 01/23/2013 04:26 AM, Jiri Denemark wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=895882 > > virDomainSnapshot.getDomain() and virDomainSnapshot.getConnect() > wrappers around virDomainSnapshotGet{Domain,Connect} were not supposed > to be ever implemented. The class should contain proper domain() and > connect() accessors that fetch python objects stored internally within > the class. While domain() was already provided, connect() was missing. > > This patch adds connect() method to virDomainSnapshot class and > reimplements getDomain() and getConnect() methods as aliases to domain() > and connect() for backward compatibility. > --- > python/generator.py | 4 +++- > python/libvirt-override-virDomainSnapshot.py | 8 ++++++++ > src/libvirt.c | 10 ++++++++-- > 3 files changed, 19 insertions(+), 3 deletions(-) > * virDomainSnapshotGetDomain: > * @snapshot: a snapshot object > * > - * Get the domain that a snapshot was created for > + * Get the domain that a snapshot was created for. > + * Missing the following (based on copy-and-paste from virDomainGetConnect): * Provides the domain pointer associated with a snapshot. The * reference counter on the domain is not increased by this * call.

ACK with those additions; no need to see a v3.