Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu
于 2011年01月11日 19:29, Daniel P. Berrange 写道:
On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote:
> If the emulator doesn't support SDL graphic, we should reject
> the use of SDL graphic xml with error messages, but not ignore
> it silently.
>
> * src/qemu/qemu_command.c
NACK.
Most previous versions of QEMU don't have any explicit -sdl
flag. You got SDL automagically when *no* -vnc flag was
given. So this change breaks many old QEMU versions.
I didn't known the older versions of QEMU don't have explicit
-sdl flag before, thanks for the knowledge, but the problem is
that qemu-kvm of RHEL removed sdl support.
* Fri Jan 15 2010 Eduardo Habkost <ehabkost(a)redhat.com> -
qemu-kvm-0.12.1.2-2.5.el6
- Remove unneeded/unsupported features: [bz#555336]
- make default options explicit
- remove sdl support
So, it means the newer qemu-kvm (of RHEL) doesn't support sdl
anymore. Didn't send the patch to Red Hat internal list,
as the patch won't conflict with upstream.
IMHO it's not reasonable that we have "sdl" xml in domain
config, but no according command line of qemu, and pretend
everything is fine.
Any good idea? Thanks
Regards
Osier