Re: [libvirt] [PATCH] network driver: Fix regression defining colliding networks at daemon startup.
On Thu, May 28, 2009 at 07:24:59PM +0100, Daniel P. Berrange wrote:
On Thu, May 28, 2009 at 01:16:25PM -0400, Cole Robinson wrote:
> If two virtual networks have the same hardcoded bridge device (which
> prevents them from being active simultaneously) we still want to define
> them at daemon startup, so the user has a fighting chance of correcting
> the XML error.
>
> Add an extra flag to SetBridge to avoid reporting an error if there is
> a bridge collision, and use this when loading network configs at startup.
>
> This regressed via commit 6c2c73fc.
>
> Signed-off-by: Cole Robinson <crobinso(a)redhat.com>
ACK
ACK to this series of 5 patches, cleanups or bug fixes, they all look
uncontroversial.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/