Re: [libvirt PATCH v2 1/1] virt-ssh-helper: Add manual page
On Mon, Jan 10, 2022 at 01:29:54PM +0100, Olaf Hering wrote:
Mon, 13 Dec 2021 14:44:51 +0100 Andrea Bolognani
<abologna(a)redhat.com>:
> +``virt-ssh-helper`` is an internal tool
If it is indeed an internal tool, why is the man page in section 1, and why is it in
PATH?
I think the man page needs to be moved to section 8, the binary into $libexec.
The path to it will be known, the shell code from virNetClientSSHHelperCommand could be
removed.
The path to the helper cannot be hardcoded, and it needs to be in
$PATH, because the shell snippet is generated on the client side but
executed on the server side. The two could have been configured with
different prefixes, as is going to be the case for example when a
macOS client connects to a Linux server.
There would be no requirement for which.rpm, which is also not noted
as Requires in libvirt.spec.
This does indeed look like a bug.
--
Andrea Bolognani / Red Hat / Virtualization