Re: [libvirt] [PATCH 27/49] daemon: Fix the wrong macro name
On 07/24/2012 08:05 AM, Guannan Ren wrote:
On 07/20/2012 10:25 PM, Osier Yang wrote:
> WITH_INTERFACE is not defined, it should be WITH_NETCF there to load
> the interface driver.
>
> Eric posted patch weeks ago to resolve the problems in the whole
> build system, but it's not finalised yet:
Indeed, I still need to find time to revisit that.
>
> https://www.redhat.com/archives/libvir-list/2012-June/msg01299.html
>
> I'm going to simply fix the wrong macro name here so that the
> interface driver could loaded, and continue the work on the listing
> API for interface driver.
> ---
> -#ifdef WITH_INTERFACE
> +#ifdef WITH_NETCF
> TEST("interface", NULL);
> #endif
> #ifdef WITH_QEMU
ACK, I need this patch, so I tested it, it's fine.
And people are starting to complain about this in F17. I went ahead and
pushed this patch now, so that we can get the fix into Fedora sooner
rather than later while I still spend time on the more complete division
of functionality between WITH_NETCF (library usage) vs. WITH_INTERFACE
(driver module).
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)