Re: [libvirt] [PATCH 12/n] conf: let snapshots share disk source struct

On 03/29/14 23:20, Eric Blake wrote: > Now that we have a common struct, it's time to start using it! > Since external snapshots make a longer backing chain, it is > only natural to use the same struct for the file created by > the snapshot as what we use for <domain> disks. >

Hmm, now that we have a common struct, we can unify the source formatter and have it accept the common struct instead of splitting out separate fields ... > type, > - disk->file, > + disk->src.path, > 0, > - disk->protocol, > - disk->nhosts, > - disk->hosts, > + disk->src.protocol, > + disk->src.nhosts, > + disk->src.hosts, > 0, NULL, NULL, 0); >

> @@ -12874,9 +12876,9 @@ qemuDomainSnapshotCreateSingleDiskActive(virQEMUDriverPtr driver, > > disk->src.path = newsource; > disk->src.format = format; > - disk->src.type = snap->type; > - disk->src.protocol = snap->protocol; > - disk->src.nhosts = snap->nhosts; > + disk->src.type = snap->src.type; > + disk->src.protocol = snap->src.protocol; > + disk->src.nhosts = snap->src.nhosts; > disk->src.hosts = newhosts; And here we can introduce a function to copy the source instead of doing it manually.

ACK to the patch. The proposed changes are definitely separable and better to review separately.