Re: [libvirt] [PATCH 13/41] remote: refactor & rename variables for building libvirtd
On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote:
The same make variables will be useful for building both libvirtd
and
the split daemons, so refactor & rename variables to facilitate reuse.
Automake gets annoyed if you define a variable ending LDFLAGS:
src/remote/Makefile.inc.am:53: warning: variable 'REMOTE_DAEMON_LDFLAGS' is
defined but no program or
src/remote/Makefile.inc.am:53: library has 'REMOTE_DAEMON' as canonical name
(possible typo)
I'd indent this by two spaces for readabilty.
You're recreating the pre-existing setup faithfully, so
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
[...]
+REMOTE_DAEMON_LD_ADD += \
+ ../gnulib/lib/libgnu.la \
+ $(LIBSOCKET) \
+ $(NULL)
As an aside, it looks like $(LIBSOCKET) is a leftover of days long
gone and no longer used for anything.
--
Andrea Bolognani / Red Hat / Virtualization