Re: [libvirt] [PATCH 2/2]virsh: remove attach-disk '--shareable' option

From: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com&gt; '--mode' option could set shareable tag already. We do not need to duplicate options. Signed-off-by: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com&gt; --- tools/virsh-domain.c | 7 ------- tools/virsh.pod | 3 +-- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ba67a69..eb5ead1 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -311,10 +311,6 @@ static const vshCmdOptDef opts_attach_disk[] = { .type = VSH_OT_STRING, .help = N_("wwn of disk device") }, - {.name = "shareable", - .type = VSH_OT_BOOL, - .help = N_("shareable between domains") - },

{.name = "rawio", .type = VSH_OT_BOOL, .help = N_("needs rawio capability") @@ -625,9 +621,6 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) if (wwn) virBufferAsprintf(&buf, " <wwn>%s</wwn>\n", wwn); - if (vshCommandOptBool(cmd, "shareable")) - virBufferAddLit(&buf, " <shareable/>\n"); -

if (straddr) { if (str2DiskAddress(straddr, &diskAddr) != 0) { vshError(ctl, _("Invalid address."));