Re: [libvirt] [PATCHv2 10/13] snapshot: simplify indentation of nwfilter

Dňa 29.9.2011 18:22, Eric Blake wrote / napísal(a): > Fixing this involved some refactoring of common code out of > domain_conf and nwfilter_conf into nwfilter_params. > > @@ -9562,15 +9561,11 @@ virDomainNetDefFormat(virBufferPtr buf, > } > } > if (def->filter) { > - virBufferEscapeString(buf, "<filterref filter='%s'", > - def->filter); > - attrs = virNWFilterFormatParamAttributes(def->filterparams, > - " "); The offset of the <filterref element is 6 spaces and of NWFilter param attributes is 8 spaces here. > - if (!attrs || strlen(attrs)<= 1) > - virBufferAddLit(buf, "/>\n"); > - else > - virBufferAsprintf(buf, ">\n%s</filterref>\n", attrs); > - VIR_FREE(attrs); > + virBufferAdjustIndent(buf, 4); Here you add a offset of 4 (the param attributes are indented 6 spaces). This probably should be set to 6 as other elements in this function are indented 6 spaces. (Look into the original mail please, if you are checking this, whitespace in this reply is mangled by thunderbird ...)

ACK with that fixed.