Re: [libvirt] [PATCH] i18n: simplify mini po generation
On Mon, May 20, 2019 at 02:59:27PM -0500, Marty E. Plummer wrote:
On Mon, May 20, 2019 at 10:14:32AM +0100, Daniel P. Berrangé wrote:
> On Sat, May 18, 2019 at 10:56:01AM -0500, Marty E. Plummer wrote:
> > If you pass --for-msgfmt to msgmerge it will automatically do most of
> > what you had the perl script doing.
>
> What msgmerge are you using as that option doesn't exist on Fedora 30
> at least ?
>
sys-deve/gettext-0.20.1 from gentoo. Didn't realize an update snuck in
on me while doing this testing.
Ok, I'm afraid we can't rely on that as we need to build with much
older distros - RHEL-7 for example.
> > Signed-off-by: Marty E. Plummer
<hanetzer(a)startmail.com>
> > ---
> > The only downside I can see is the loss of the comment headers with the
> > copyright year and such. A global note in the README.md or so may be an
> > acceptable change.
>
> Removal of copyright strings is a no-go, as that is a violation of
> licensing terms unless it is your own copyright notice you are
> removing.
>
>
Here's an idea I came up with to avoid this: move the copyright stuff
out of a comment and add it to a translatable string, like so:
That's changing the format of the file which is not something I
wish to do. Since we can't rely on that new gettext it doesn't
really matter though, since we can't take this approach at all.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|