Re: [libvirt] [PATCH] Allow custom metadata in network configuration XML
On Fri, Jun 24, 2016 at 12:26:22 -0400, Laine Stump wrote:
On 06/24/2016 07:01 AM, Peter Krempa wrote:
> On Wed, Jun 22, 2016 at 16:05:50 -0600, Brnadon Bennett wrote:
>> From: Brandon Bennett <bbennett(a)fb.com>
>>
>> This replicates the metadata field found in the domain configuration
>> and adds it to the network configuration XML.
> Just a few notes before Laine pushes the patch:
[...]
As Brandon commented elsewhere, there is still the
virNetwork(Get|Set)Metadata() APIs to add, but even the ability to have
it in the XML is useful (for example, in the case of a network hook script).
The setter API is necessary if you want to tweak the metadata for a
running network, so it's necessary for any kind of dynamic metadata.
It's okay to add it later though similarly as it was done with domain
metadata.
Peter