Re: [libvirt] [PATCH 2/2] blockjob: wire up online qemu block-commit

On 10/05/2012 12:53 PM, Kashyap Chamarthy wrote: With qemu.git and with my patches applied (they are not yet in libvirt.git, so you'll have to apply them yourself to test): Assuming that you have a domain with just one disk, labeled 'vda' according to 'virsh domblklist', then... virsh blockcommit $dom vda --wait --base /path/to/base --top /path/to/snap-3 Note that your chain has to use absolute backing file names in the current state of qemu.git (Jeff is working on a patch to work with chains that used relative backing file names). Also, note that the patches I have posted so far do not interact with existing libvirt snapshots, so while you can verify that the disk images have been properly modified (for example, after the commit completes, stop the domain, then use qemu-img info active-layer to see that active-layer's backing image is now base instead of snap-3), the fact that you did a commit may make it harder to use any snapshots you created via 'virsh snapshot-create --disk-only' to create the long chain in the first place. Similar to case-1, except that now you use --base snap-1. Similar to case-1, except that now you use --top snap-2. Yep - requires a running guest at the moment (I'm still trying to get patches to support offline guest commits, using qemu-img, but it's taking a while to iron out the design work necessary to track a child qemu-img across libvirtd restarts). -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org