Re: [libvirt PATCH v3 05/12] gitlab: reduce number of cross build jobs run by default
On Thu, Mar 26, 2020 at 02:40:22PM +0100, Andrea Bolognani wrote:
On Thu, 2020-03-26 at 12:35 +0000, Daniel P. Berrangé wrote:
> Currently we nine different cross build jobs
You accidentally a verb here :)
heh, s/we/we have/
[...]
> +# Extra cross build jobs that are only run post-merge, or
> +# when code is pushed to a branch with "ci-extra-" name prefix
> +.cross_build_extra_job_template: &cross_build_extra_job_definition
> + <<: *cross_build_default_job_definition
> + only:
> + - master
> + - /^ci-extra-.*$/
Can I suggest the changing the expected prefix from ci-extra to
ci-full? Because when you push to that branch you get the full set
of build jobs, not just the extra ones.
Sure, works for me.
Regardless,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|