Re: [libvirt] [PATCH v2 2/3] virsh: Pass vshControl to all vshCommandOpt*() calls.
On Wed, 2015-05-27 at 16:47 +0200, Michal Privoznik wrote:
> - bool config = vshCommandOptBool(cmd, "config");
> + bool config = vshCommandOptBool(ctl, cmd, "config");
I don't think this is needed. vshCommandOptBool should never return an
error. Well, it's returning just if a flag was specified or not.
I added it in to keep all vshCommandOpt*() calls consistent, but since
both you and Peter feel like it shouldn't be there I'll get rid of it.
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team
$ python -c "print('a'.join(['', 'bologn', '@redh',
't.com']))"