Re: [libvirt] [PATCH] util: Compile error

On 11/11/2011 04:23 PM, Eric Blake wrote: > On 11/11/2011 01:36 AM, Eli Qiao wrote: >> >> 于 2011年11月11日 16:33, Dong Xu Wang 写道: >>> Sorry, the title is "util: Compile error", what's the usage of this >>> patch? >>> Without applying this, it will cause error while compiling? >> yes , when run make ,it will cause undefined symbols error. > Can you post those actual errors, and which platform you were on when > you encountered them? Never mind; I reproduced the failure on Ubuntu. ../src/.libs/libvirt_driver_qemu.a(libvirt_driver_qemu_la-qemu_command.o): In function `qemuNetworkIfaceConnect': /home/eblake/libvirt/src/qemu/qemu_command.c:259: undefined reference to `virNetDevTapCreateInBridgePort' ... Fedora still allows symbol resolution by transitive dependency, but Ubuntu's default linker settings were recently changed to forbid that (that is, if liba depends on libb depends on libc, Fedora will let liba use symbols from libc, but Ubuntu will not; and you have to either re-export the symbols from libb [this patch], or add another link line to liba [a bit more work in the various Makefile.am files]). Your patch looks correct, so ACK and pushed. I also added you to AUTHORS; let me know if you need any preferred spellings altered.