Re: [libvirt] [PATCH] virsh: schedinfo --set invalid=value would simply ignore the option
On 05/11/2010 08:00 AM, Jim Meyering wrote:
Currently, virsh does this:
$ virsh -c test:///default schedinfo 1 --set j=k>/dev/null && echo bad
bad
It should have diagnosed "j=k" as an invalid schedinfo --set argument.
+
+: ${srcdir=$(pwd)}
As long as we are assuming a modern shell with $() support, can't we
also assume that $PWD is reliable and save a fork?
At any rate, ACK.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)