Re: [libvirt] [jenkins-ci PATCH 17/17] Switch libvirt-dbus builds to meson
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
+++ b/guests/playbooks/build/projects/libvirt-dbus.yml
+- include: '{{ playbook_base }}/jobs/meson-check-job.yml'
vars:
# CentOS 7 doesn't include Python 3, while the versions of flake8
# and pyflakes currently available on FreeBSD (3.5.0 and 2.0.0
# respectively) are not compatible
+ # Python 3 version in Ubuntu 16.04 is too old
The part of the comment talking about CentOS 7 is clearly no longer
accurate, so we either need to enable this job on the target or leave
it disabled but update the comment to point out the current reason we
need to do so.
+++ b/jenkins/projects/libvirt-dbus.yaml
+ - meson-check-job:
parent_jobs: 'libvirt-dbus-build'
# CentOS 7 doesn't include Python 3, while the versions of flake8
# and pyflakes currently available on FreeBSD (3.5.0 and 2.0.0
The comments has not been updated here.
I know that mentioning Ubuntu is technically not necessary here
because we don't (yet) have any Ubuntu builder in our CentOS CI
environment, but despite that I prefer keeping everything, even the
comments, in sync between the Ansible and Jenkins parts.
With the comment fixed and propagated to the Jenkins part,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization