Re: [Libvir] Network blocking issue
On Mon, Sep 17, 2007 at 03:35:19PM -0400, Daniel Veillard wrote:
On Mon, Sep 17, 2007 at 03:57:03PM +0100, Richard W.M. Jones wrote:
> Daniel P. Berrange wrote:
> >My definition is that TCP should keep retrying until I plug the cable back
> >in, so I don't get unneccessary failures if i'm just switching cables
> >around. Likewise if there's temporary outages anywhere else in the link
> >between the client & server.
>
> Yes actually I agree with you on that one. On the other hand there is
> no way for Shuveb to set TCP socket options on the socket other than
> making a private copy of the libvirt code and hacking it. So a patch to
> add yet another query string flag to the remote URI or to expose the
> remote socket somehow might be acceptable.
Expectations will vary according to environments. But 15mn is *way* over
what I would accept in a distributed system environment. On the other hand
when ssh resumes the connection fine if I suspend my laptop for 30mn is
a a feature. That's why I ask for a way to set the timeout, I don't think
we will be able to find a value which will please everybody.
I'm not in favour of providing a configurable timeout to individual apps using
libvirt because it'll lead to inconsistent behaviour between apps/ ie scenarios
where one libvirt app will continue to work while another will prematurely
fail. It'll also mean that every app using libvirt will have to find a way
to expose this setting to the user.
I'm not too fond of using an extension to the URI, I think this
gets over
what URI were designed for. Either giving an access to the socket descriptor
(beware this may generate a future Windows portability problem), or provide
a specific tuning API (not nice but relatively safe). Since calls are
synchronous the app may change the Connection timeout before issuing some
calls like Create or Migrate.
Yep, a timeout isn't really part of an address which is what we're using
URIs for. Exposing new APIs for this to the apps isn't nice because of the
need for all apps to then expose it to the user as i mention above.
Other possibilities are a libvirt client side config file or environment
variables but the latter isn't too nice.
I'd probably go for config file unless people have other ideas.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|