Re: [libvirt] [PATCH] build: fix 'make check' linkage with dtrace
On 10/11/2011 01:59 PM, Jiri Denemark wrote:
On Tue, Oct 11, 2011 at 13:54:40 -0600, Eric Blake wrote:
> Building on Linux with dtrace enabled was failing 'make check':
>
> CCLD nodeinfotest
> ../src/.libs/libvirt_test.a(libvirt_net_rpc_client_la-virnetclient.o): In function
`virNetClientNew':
> /home/remote/eblake/libvirt/src/rpc/virnetclient.c:162: undefined reference to
`libvirt_rpc_client_new_semaphore'
>
>
> I'm still in the middle of running ./autobuild.sh, but if that
> fixes the VPATH build there, then I will push this under the
> build-breaker rule.
>
> tests/Makefile.am | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
I pushed my patch and checked that your patch fixes the make check errors in
VPATH build.
ACK
My testing passed as well. Now pushed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org