Re: [libvirt] [PATCH] Autogenerate AUTHORS

On 10/18/2012 02:23 PM, Cole Robinson wrote: Can we sort this portions of AUTHORS.in, to match the fact that the rest of our file will be in sorted order? I know we require POSIX sh in our GNUmakefile, but in Makefile.am, it's probably still safer to use `` instead of $(). Why not use 'sort -u' and shave off a process? VPATH build needs $(srcdir)/AUTHORS.in. Useless use of cat. I think the use of perl is overkill; sed can do the same. Oh, and sed can also get us to aligned columns, by exploiting the fact that none of our names contain ~ (admittedly, my sed script now looks like line noise): if test -d .git; then \ out=`git log \ --pretty='%aN~~~~~~~~~~~~~~~~~~~~~~~~<%aE>\' | \ sort -u | \ sed 's/^\(.\{24\}[^~]*\)~*</\1~</; s/~/ /g'` && \ sed -e '/#authorlist#/ c\' -e "$$out" -e'' \ < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \ mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS \ fi For that matter, we can even get fancy with sed to merge both the list of git authors and old authors from AUTHORS.in in one go. First, prep AUTHORS.in correctly: ... Patches have also been contributed by: #1# older names #2# [....send patches to get your name here....] then you can do something like: if test -d .git; then \ out=`{ sed -n '/#1#/,/#2#/ < $(srcdir)/AUTHORS.in; \ git log \ --pretty='%aN~~~~~~~~~~~~~~~~~~~~~~~~<%aE>\'; } | \ sort -u | \ sed 's/^\(.\{24\}[^~]*\)~*</\1~</; s/~/ /g'` && \ sed -e '/#1#/,/#2#/ c\' -e "$$out" -e'' \ < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \ mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS \ fi (I only lightly tested the above, it may still need tweaks) Merge these two lines into one: touch AUTHORS ChangeLog || exit 1 -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org