On Thu, Apr 12, 2018 at 09:14 AM +0200, Michal Privoznik <mprivozn(a)redhat.com>
wrote:
In 2ada9ef1465f we've tried to turn virDomainChrSourceDef into
virObject. Well, this requires 'virObject' member to be stored on
the first position of the struct. This adjustment is missing in
the original commit leading to all sorts of funny memleaks and
data corruptions.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/conf/domain_conf.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 89a7131fdb..1426f115ed 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -57,6 +57,7 @@
# include "virtypedparam.h"
# include "virsavecookie.h"
# include "virresctrl.h"
+# include "virobject.h"
/* forward declarations of all device types, required by
* virDomainDeviceDef
@@ -1180,6 +1181,7 @@ typedef virDomainChrSourceReconnectDef
*virDomainChrSourceReconnectDefPtr;
/* The host side information for a character device. */
struct _virDomainChrSourceDef {
+ virObject parent;
int type; /* virDomainChrType */
virObjectPtr privateData;
union {
--
2.16.1
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Oh… :/
With the fix suggested by Erik
Reviewed-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com>
--
Beste Grüße / Kind regards
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294