Re: [libvirt] [PATCH 2/2] add vnc unix sockets to apparmor policy (v2)
On 12/11/2012 01:25 PM, Daniel P. Berrange wrote:
On Tue, Dec 11, 2012 at 08:20:30PM +0000, serge(a)hallyn.com wrote:
Instead of putting '(v2)' as a suffix (which I then have to manually
strip via 'git commit --amend'), it is nicer to put it in the prefix
[PATCHv2 2/2] (doable with 'git send-email --subject-prefix=PATCHv2',
and which gets auto-stripped by 'git am').
> From: Serge Hallyn <serge.hallyn(a)ubuntu.com>
>
> When using vnc gaphics over a unix socket, virt-aa-helper needs to provide
> access for the qemu domain to access the sockfile.
>
> Changelog:
> v2: add testcase to virt-aa-helper-tests to make sure xml with vnc socket
> works.
Likewise, patch changelogs belong best after a --- separator; it's
useful for the review, but doesn't need to live in git history.
> + for (i = 0; i < ctl->def->ngraphics; i++) {
> + if (ctl->def->graphics[i]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC
&&
> + ctl->def->graphics[i]->data.vnc.socket &&
> + vah_add_file(&buf,
ctl->def->graphics[i]->data.vnc.socket, "rw"))
Odd indentation alignment
I fixed the commit messages and this alignment,
ACK
then pushed the series.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)