Re: [libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin
On 07/17/2018 08:46 PM, John Ferlan wrote:
On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> Introduce one basic test that tests the simplest case:
> logging into portal without any IQN.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> ---
> tests/viriscsitest.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
FWIW: This is successful for me w/o patch 6
Of course it is. The testIscsiadmCb() is not failing because of hunk 1.
But try removing both patch 6 AND the first hunk (so that
testIscsiadmCb() sets *status = -1;).
I guess now you can see my reasoning for patch 6.
Michal