Re: [libvirt] [PATCH v3] nwfilter: extend nwfilter reload support

Please respond to "Daniel P. Berrange" On Fri, Aug 13, 2010 at 04:36:32PM -0400, Stefan Berger wrote: > > > This time with a proper title. > > v3: > - Fixed an indentation problem > > - added bool parameter to function terminating the IP address > learner threads to determine whether future threads may still run > (needed in case of driver reload) or all must terminate (need in case

> libvirtd termination) > > v2: > > - Fixes to the nwfilter driver reload function that also needs a > valid virConnectPtr. > > In this patch I am extending and fixing the nwfilter module's reload > support to stop all ongoing threads (for learning IP addresses of > interfaces) and rebuild the filtering rules of all interfaces of all

> when libvirt is started. Now libvirtd rebuilds the filters upon the > SIGHUP signal and libvirtd restart. > > About the patch: The nwfilter functions require a virConnectPtr. > Therefore I am opening a connection in qemudStartup, which later on > needs to be closed outside where the driver lock is held since

> it ends up in a deadlock due to virConnectClose() trying to lock the > driver as well. > > I have tested this now for a while with several machines running and > needing the IP address learner thread(s). The rebuilding of the

> rules seems to work fine following libvirtd restart or a SIGHUP. Also > the termination of libvirtd worked fine. > > > Signed-off-by: Stefan Berger<stefanb(a)us.ibm.com> >

This identation still seems to be wrong - so was the code being replaced. ACK aside from that Daniel