Re: [libvirt] [PATCH v3] Introduce --without-pm-utils to get rid of pm-is-supported dependency
On 04/02/2014 07:35 AM, Cédric Bosdonnat wrote:
This uses the dbus api of systemd to check the power management
capabilities of the node.
---
Diff with v2:
* Fixed a few dbus call problems
+++ b/configure.ac
@@ -563,6 +563,10 @@ AC_ARG_WITH([chrdev-lock-files],
[location for UUCP style lock files for character devices
(use auto for default paths on some platforms) @<:@default=auto@:>@])])
m4_divert_text([DEFAULTS], [with_chrdev_lock_files=auto])
+AC_ARG_WITH([pm-utils],
+ [AS_HELP_STRING([--with-pm-utils],
+ [use pm-utils for power management @<:@default=yes@:>@])])
+m4_divert_text([DEFAULTS], [with_pm_utils=yes])
Should the default really be yes? On systems where dbus is not in use,
'yes' as the default makes sense. But on systems where dbus is active,
and where we know we are using systemd for other configure options,
wouldn't it make more sense to default pm-utils to no in that case? Or
in other words, set default=check, then use other configure options to
decide whether to flip check to no (systemd and dbus detected) or to yes
(all other cases), rather than hard-coding to yes.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)