Re: [PATCH] qemu: Add GTK display with OpenGL support
On Mon, Apr 28, 2025 at 12:33:19 +0200, Peter Krempa via Devel wrote:
On Mon, Apr 28, 2025 at 12:22:22 +0200, Kirill Shchetiniuk via Devel
wrote:
> From: Kirill Shchetiniuk <kshcheti(a)redhat.com>
>
> Introduce GTK display support with OpenGL for the QEMU driver.
>
> - Add new XML options for GTK display type.
> - Include capability flags for the QEMU driver.
>
> Note: The `QEMU_CAPS_GTK_GL` flag cannot yet be checked, so device
> definition validation is incomplete. A placeholder is left for
> future implementation, when the GTK along with OpenGL capability
> check would be available in QEMU.
Can you elaborate? WHy can't it be checked?
Since the 'gtk' backend in support was introduced predating qemu-2.12.
I'm guessing what's happening is that you tried to use
DO_TEST_CAPS_LATEST which failed.
For the above the solution is not to ignore the check but rather one of:
1) update the 'x86_64' test data with a qemu built with gtk support
2) add a variant of the test data from a qemu built with gtk support
3) use DO_TEST_FULL and ARG_FLAGS to add the capability for the test
file
4) base the tesst on one of the other arches which were built wit gtk
Since I'm the one maintaining the capability dumps, maitaining a variant
for this is overkill; adding it to the main build is possible (I can
send the update).
I was historically building qemu with '--disable-gtk' as it mirrored
what fedora was doing but it seems that GTK is enabled in the current
fedora build.
Option 3) is acceptable for a niche feature and option 4) can
theoretically regress in the future.