Re: [libvirt] [PATCH] esx: Use MD5 sum of mount path as storage pool UUID
On 08/09/2010 06:56 AM, Matthias Bolte wrote:
With the previous storage pool UUID source not all storage pools
had a proper UUID, especially GSX storage pools. The mount path
is unique per host and cannot change during the lifetime of the
datastore. Therefore, its MD5 sum can be used as UUID.
Use gnulib's crypto/md5 module to generate the MD5 sum.
Just as a general thought, would it be preferably to use the SHA1
function instead of the MD5 one?
Asking because MD5 seems to be trending "out of favour" (as a
generalisation) compared to SHA1, after some cryptographers showed MD5
hash collisions could be practically achieved with some types of data.
(or something along those lines)
For all intents and purposes, I'm thinking it'll make no practical
functional difference, but figure it's worth asking. :)
Regards and best wishes,
Justin Clift