Re: [libvirt] [PATCH] lxcDomainShutdownFlags: Cleanup @flags usage

>>> + >>> + if (initctlRequested || !flags) >>> + useInitctl = true; >> >> I'm not sure this logic is right. > > Yuck - commit aa4619337 is broken. > >>

> > This is still unfortunately the case in what you pushed. And how come > you didn't do the same treatment to lxcDomainReboot, which also has two > different flags where we need proper fallback when initctl is > unsupported? Your commit conflicts with the pending CVE-2013-6456 > efforts (my patch at [1]), so we need to get this resolved. > > [1] https://www.redhat.com/archives/libvir-list/2013-December/msg01249.html > Yep, I've pushed it accidentally. I've merged a branch which wasn't rebased onto master but onto a different local brach containing this commit. I suggest reverting my commit. I'll post better version (with lxcDomainReboot) then. Sorry for the noise.