On Mon, Nov 06, 2023 at 02:21:16AM -0800, Andrea Bolognani wrote:
On Mon, Nov 06, 2023 at 09:58:02AM +0000, Daniel P. Berrangé wrote:
> On Mon, Nov 06, 2023 at 01:47:20AM -0800, Andrea Bolognani wrote:
> > On Mon, Nov 06, 2023 at 10:37:28AM +0100, Martin Kletzander wrote:
> > > Ah, since the switch to the new ML I cannot apply any patch using git
> > > am:
> > >
> > > warning: quoted CRLF detected
> > > Applying: ci: workaround broken opensuse leap 15.5 tirpc
> > > Using index info to reconstruct a base tree...
> > > error: patch failed: ci/gitlab/builds.yml:332
> > > error: ci/gitlab/builds.yml: patch does not apply
> > > error: patch failed: ci/manifest.yml:205
> >
> > Yeah, both me and Laine noticed this the other day. Patches look fine
> > in mutt, but if you save them to a file they end up looking all wonky
> > (see attached file for an example) and 'git am' won't like them.
>
> Well that's strange.
>
> The version I sent was
>
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> What you have attached is
>
> Content-Type: text/plain; charset="utf-8"
> Content-Transfer-Encoding: base64
>
> Meanwhile when downloading from the archives
>
> Content-Type: text/plain; charset="utf-8"
> Content-Transfer-Encoding: quoted-printable
>
> IOW, something in the mail chain is screwing around with the content.
>
> Aside from harming git am, this is almost certainly going to doom
> DKIM signatures and GPG signatures covering the content.
So does that mean that the issue is server-side? I'm pretty sure
Laine, Martin and I are all fetching emails using different tools, so
that would sound more plausible, but it's weird that things
apparently work fine for you?
I guess I tested the wrong mail. I can apply patches from Laine, but
I cannot apply from Michal.
I think the trigger is non-ASCII7 characters (ie accents) in the sender
name (or possibly the Signed-off-by), causing software to re-encode turn
the message into base64
With regards,
Daniel
--
|:
https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|:
https://libvirt.org -o-
https://fstop138.berrange.com :|
|:
https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|