Re: [libvirt] [PATCH 2/3] Add virBufferEscapeShell
On Thu, Oct 13, 2011 at 03:25:10PM -0600, Eric Blake wrote:
On 10/13/2011 03:02 PM, Guido Günther wrote:
>On Wed, Oct 12, 2011 at 05:16:35PM -0600, Eric Blake wrote:
>>On 10/12/2011 04:39 PM, Guido Günther wrote:
>>>Escape strings so they're safe to pass to the shell. Based on glib's
>>>g_quote_string.
>>
>>Is this still true, or does it now resemble more what I did
>>(independently from g_quote_string) in tools/virsh.c cmdEcho?
>
>Yes, it's more like cmdEcho now ;)
>>>+++ b/src/libvirt_private.syms
>>>@@ -29,6 +29,7 @@ virBufferEscape;
>>> virBufferEscapeSexpr;
>>> virBufferEscapeString;
>>> virBufferFreeAndReset;
>>>+virBufferEscapeShell;
>>
>>Sort this line (up a couple).
>@@ -28,6 +28,7 @@ virBufferError;
> virBufferEscape;
> virBufferEscapeSexpr;
> virBufferEscapeString;
>+virBufferEscapeShell;
> virBufferFreeAndReset;
One more line up (Shell comes _before_ String :)
Ahh...sorted alphabetically that is (as the comment says). I tried to
keep the same order as in the header (as good as possible).
ACK with that nit fixed.
Pushed all three patches, thanks,
-- Guido
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org