Re: [libvirt] [PATCH 09/14] Fix check for whether a suspend target is supported
On 11/29/2011 08:44 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange(a)redhat.com>
hostPMFeatures is a bitmask, but the VIR_NODE_SUSPEND_TARGET
constants are from an enum. Thus the code was checking the
wrong bit values
Yep - regression introduced in patch 1/14. Maybe you should squash this
in to that patch, so that bisecting doesn't hit the regression (although
that would mean patching a different file, since you moved the function
location in the meantime). Up to you if you want to go to the hassle.
ACK whether rebased and squashed, or done here as a separate patch.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)