On 09/17/2013 09:23 AM, Daniel Veillard wrote:
On Tue, Sep 17, 2013 at 09:04:46AM +0200, Wido den Hollander wrote:
> On 09/16/2013 07:58 AM, Daniel Veillard wrote:
>> Raising this due to maven
>>
>> On Fri, Sep 13, 2013 at 05:26:24PM +0800, Daniel Veillard wrote:
>>> On Fri, Sep 13, 2013 at 11:13:53AM +0200, Wido den Hollander wrote:
>>>>
>>>>
>> [...]
>>>
>>> Indeed that was the problem, I just commited the fix, thanks !
>>
>
> Somewhat related to this: It seems you have compiled with Java 7
> causing the bindings not to work with Java 6.
>
> A lot of users are still running Java 6 on their systems.
>
> You could do this with in build.xml:
>
> <javac target="1.6" .../>
>
> Or something like:
>
> <property name="javac.target" value="1.6" />
> ..
> <javac target="${javac.target}" .../>
>
> Java 6 is still around and I think it should be supported for older
> platforms.
I just compiled with the java available in my system (fedora 19).
Do one really need to release for every version of java potentially
using libvirt-java ?
Can't they just rebuild locally too ?
Sure, but if the code in
libvirt.org/maven2 is Java 1.7 systems building
with Maven and using Java 1.6 can't use it.
There is no special code in libvirt-java which requires Java 1.7 to operate.
By setting the source and target version to 1.6 the code will run on at
least 1.6, but will work just fine on 1.7 systems.
It's mainly a compatibility thing.
I take patches :-) as build.xml is in git
Just sent a patch :)
Wido
Daniel