On 01/06/2018 12:47 AM, John Ferlan wrote:
Let's make sure that non SCSI virtio-scsi isn't used for any type other than a virtio-scsi controller.
This includes removing the check from qemuCheckSCSIControllerIOThreads which is a very suble difference because although def->model was used in the original comparison and just @model is used in the new comparison, the comparison is the same.
This is because qemuDomainSetSCSIControllerModel doesn't change the def->model, thus we know that the resultant @model would result in either the same as input or if not set, whatever the default model is when def->model == -1. In this second case, virtio-scsi is the last default chosen.
Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/qemu/qemu_command.c | 8 -------- src/qemu/qemu_domain.c | 5 +++++ 2 files changed, 5 insertions(+), 8 deletions(-)
ACK Michal