Re: [libvirt] [PATCH 3/4] security, apparmor: add (Set|Restore)ChardevLabel

> + char *in = NULL, *out = NULL; > + int ret = -1; > + > + virSecurityLabelDefPtr secdef = virDomainDefGetSecurityLabelDef(def, > + SECURITY_APPARMOR_NAME); > + if (!secdef) > + return 0; There shouldn't be empty line in variable declaration. However, there should be one after the block. BTW: here and in the function below - if we need to call a function with a long name to initialize a variable we usually do that on a separate line.