Re: [libvirt] [PATCH] cpu-driver: Fix the cross driver function call

On Thu, Nov 20, 2014 at 11:08:21AM +0100, Daniel Hansel wrote: > For Intel and PowerPC the implementation is calling a cpu driver > function across driver layers (i.e. from qemu driver directly to cpu > driver). > The correct behavior is to use libvirt API functionality to perform such > a inter-driver call. > > This patch introduces a new cpu driver API function getModels() to > retrieve the cpu models. The currect implementation to process the > cpu_map XML content is transferred to the INTEL and PowerPC cpu driver > specific API functions. > Additionally processing the cpu_map XML file is not safe due to the fact > that the cpu map does not exist for all architectures. Therefore it is > better to encapsulate the processing in the architecture specific cpu > drivers. > > Signed-off-by: Daniel Hansel <daniel.hansel(a)linux.vnet.ibm.com&gt; > Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com&gt; > Reviewed-by: Viktor Mihajlovski <mihajlov(a)linux.vnet.ibm.com&gt; > --- > src/cpu/cpu.c | 68 +++++++++------------------------------------------ > src/cpu/cpu.h | 4 +++ > src/cpu/cpu_powerpc.c | 37 ++++++++++++++++++++++++++++ > src/cpu/cpu_x86.c | 33 +++++++++++++++++++++++++ > 4 files changed, 86 insertions(+), 56 deletions(-) ACK