Re: [libvirt] [PATCH 1/5] util: Introduce function for allocating virStorageSource
On Mon, Feb 18, 2019 at 10:16:25AM +0100, Peter Krempa wrote:
On Mon, Feb 18, 2019 at 08:29:14 +0100, Erik Skultety wrote:
> On Fri, Feb 15, 2019 at 01:42:09PM +0100, Peter Krempa wrote:
> > Add virStorageSourceNew and refactor places allocating that structure to
> > use the helper.
> >
> > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> > ---
> Looks like you caught all the occurrences but 1 in bhyve: bhyveParsePCIDisk
> With that addressed too:
Instead of changing that in this patch I propose we fix the bhyve parser
properly:
https://www.redhat.com/archives/libvir-list/2019-February/msg00956.html
Yep, makes sense.
Thanks,
Erik