Re: [libvirt] [PATCH] docs: correct setmem text plus expand setmaxmem text
On 20/01/2011, at 11:30 PM, Matthias Bolte wrote:
2011/1/19 Justin Clift <jclift(a)redhat.com>:
> This completes the man page updates required for BZ # 622534:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=622534
> -Change the maximum memory allocation limit in the guest domain. This should
> -not change the current memory use. The memory limit is specified in
> -kilobytes.
> +Change the maximum memory allocation limit for an active guest domain.
> +
> +Some hypervisors require a larger granularity than kilobytes, and requests
> +that are not an even multiple will either be rounded down or rejected. For
> +example, vSphere/ESX rejects the parameter unless the kB argument is evenly
> +divisible by 1024 (that is, the kB argument happens to represent megabytes).
Actually vSphere/ESX truncates in this case. It rejects in other cases
(virsh define).
As Dan suggested, I might change this to round up.
No worries. Looks like the man page is about to get more complicated. Heh.
With the "round up" approach, no real issues with that. It *would* be printing
some
kind of warning message though wouldn't it, alerting the user that what they asked
for isn't what they got?