Re: [libvirt] [PATCH] Fix serial console telnet protocol support
On Wed, Aug 13, 2008 at 06:44:28PM +0100, Mark McLoughlin wrote:
With e.g.:
<serial type='tcp'>
<source mode='bind' host='127.0.0.1' service='4444'/>
<protocol type='telnet'/>
<target port='0'/>
</serial>
You currently get:
Unknown option: listen
qemu: could not open serial device 'telnet:127.0.0.1:4444,listen'
With the telnet protocol, qemu expects "server" as an option
rather than "listen".
ACK, but can you also fix the test case for this to match before
committing. We're currently validating that it is 'listen' :-)
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|