Re: [libvirt] [PATCH] use model "qemu" for s390 tcg cpu-model-expansion

On Mon, Jul 23, 2018 at 17:45:32 -0400, Collin Walling wrote: > When calling the query-cpu-model-expansion command via libvirt, we pass in model > name "max" when using TCG. However, this model name is not supported for s390 on > TCG. Let's use the model name "qemu" as an alternative. > > QEMU Results: > > When executing query-cpu-model-expansion via QEMU on s390 with TCG, the name "max" > results in this error: > > { "execute": "query-cpu-model-expansion", "arguments": {"type": "static", "model": {"name": "max"}}} > > -> {"error": {"class": "GenericError", "desc": "The CPU definition 'max' is unknown."}} > > An alternative is to use model name "qemu." On a z13.2 machine: > > { "execute": "query-cpu-model-expansion", "arguments": {"type": "static", "model": {"name": "qemu"}}} > > -> {"return": {"model": {"name": "zEC12.2-base", "props": {"dateh2": false, "aen": true, "kmac-tdea-192": false, > "kmc-tdea-192": false, "parseh": false, "csske": false, "hfpm": false, "hfpue": false, "dfp": false, "km-dea": false, > "emon": false, "kimd-sha-1": false, "cmpsceh": false, "dfpzc": false, "dfphp": false, "kmc-dea": false, > "klmd-sha-1": false, "asnlxr": false, "km-tdea-192": false, "km-tdea-128": false, "fpe": false, "kmac-dea": false, > "kmc-tdea-128": false, "ais": true, "kmac-tdea-128": false, "nonqks": false, "pfpo": false, "msa4-base": true, > "msa3-base": true, "tods": false}}}} Providing a cover letter for a single patch is pointless, all contents which you would put in it should go into the commit message of the patch itself.

> I am by all means *not* an expert in TCG, but I noticed this error while I was messing > around with things on my system. Except this, but you could put it after ---

Jirka -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list