Re: [libvirt] [PATCH] Fix common misspellings

On 03/20/2015 06:21 AM, Martin Kletzander wrote: > Wikipedia's list of common misspellings [1] has a machine-readable > version. This patch fixes those misspellings mentioned in the list > which don't have multiple right variants (as e.g. "accension", which can > be both "accession" and "ascension"), such misspellings are left > untouched. The list of changes was manually re-checked for false > positives. > > [1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_... > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > This is in no way automated, it's merely a check on whether this makes > sense. Also I left out three words and two files which I thought > might not be what we want. Quite the list! As a native speaker... > +++ b/docs/bugs.html.in > @@ -11,7 +11,7 @@ > > <p> > If you think that an issue with libvirt may have security > - implications, <strong>please do not</strong> publically > + implications, <strong>please do not</strong> publicly Correct. > +++ b/docs/schemas/basictypes.rng > @@ -115,7 +115,7 @@ > <!--interface on a device (system). The duid is often used by servers --> > <!--such as dnsmasq to assign a specific IP address (and optionally a --> > <!--name to an interface. The applicable standards are RFC3315 and --> > - <!--RFC6355. These standards actualy require the duid to be fixed for --> > + <!--RFC6355. These standards actually require the duid to be fixed for --> > <!--the hardward device and applicable to all network interfaces on --> Alignment is now off. > +++ b/docs/schemas/interface.rng > @@ -4,7 +4,7 @@ > xmlns:v="http://netcf.org/xml/version/1.0" > datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> > <!-- Versions for this schema are simple integers that are incremented > - everytime a changed (but backwards compatible) version > + every time a changed (but backwards compatible) version > is released. The current version is indicated with the v:serial > attribute on the start element. > --> Hmm - we aren't really bumping the version when we change the .rng; is that a bug in our process, or a stale comment worth deleting instead of spell-checking? But doesn't stop us from taking this hunk now.

> @@ -77,7 +77,7 @@ > are two weeks or less in duration. If a problem is identified > with a proposed patch for a security issue, requiring further > investigation and bug fixing, the embargo clock may be restarted. > - In exceptional circumstances longer initial embargos may be > + In exceptional circumstances longer initial embargoes may be This one is ambiguous (I've seen both spellings; zeros/zeroes is another such word), but Thunderbird's US spell-check dictionary prefers embargoes, so go for it.

ACK to all these changes (modulo the alignment fix).