Re: [libvirt] [PATCH 02/23] util: buffer: Add API to set indentation level to a given value
On 03/23/2017 02:14 AM, Peter Krempa wrote:
>
> No testsuite addition?
For such trivial operation? I think we have pretty strong coverage of
the indentation code. This simple setter isn't worth it IMO.
I don't see how adding one or two lines to the testsuite, to ensure we
don't break this new interface, is not worth it. Yes, we have a lot of
good coverage already, so let's keep it good, rather than introducing
holes in the coverage as we add new stuff.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)