Re: [libvirt] [PATCH 5/6] qemu: Use storage driver APIs in qemuDomainBlockPeek
On Sat, Jul 01, 2017 at 10:43:23 -0400, John Ferlan wrote:
On 06/23/2017 09:33 AM, Peter Krempa wrote:
> Refactor the access to storage driver usage along with
> qemuDomainStorageFileInit which ensures that we access the file with
> correct DAC uid/gid.
> ---
> src/qemu/qemu_driver.c | 25 ++++++++-----------------
> 1 file changed, 8 insertions(+), 17 deletions(-)
>
Irony is the comment at the end of qemuOpenFile:
* This function should not be used on storage sources. Use
* qemuDomainStorageFileInit and storage driver APIs if possible.
This message was added by:
commit f7105d0e4a485bf7d9e878fd17e675d7f9d29f9f
Author: Peter Krempa <pkrempa(a)redhat.com>
Date: Wed May 10 12:28:38 2017 +0200
the usage of qemuOpenFile (prior to that, open() was used directly) was
added in:
commit b4a40dd92dc7e6f110b13f2353cb5343d1147227
Author: Martin Kletzander <mkletzan(a)redhat.com>
Date: Fri May 24 18:26:26 2013 +0200
I was just lazy and did not bother fixing all places right away and
added the warning that it shouldn't be reused more.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)