On Mon, Feb 26, 2018 at 12:20:49PM +0100, Erik Skultety wrote:
On Mon, Feb 26, 2018 at 11:59:26AM +0100, Michal Privoznik wrote:
> On 02/25/2018 11:45 PM, Erik Skultety wrote:
> > Erik Skultety (2):
> > docs: logos: Remove empty text elements from the banner SVGs
> > docs: logos: Resize the 'Drop shadow' filter bounding box
> >
> > docs/logos/logo-banner-dark.svg | 39 +++++----------------------------------
> > docs/logos/logo-banner-light.svg | 39 +++++----------------------------------
> > 2 files changed, 10 insertions(+), 68 deletions(-)
> >
>
>
> ACK and safe for freeze. Don't we need to regenerate PNGs esp. after 2/2?
Well, actually, yes, we should, I'll do that later today, but for a different
reason - for PNG, you'd normally just resize the canvas if spacing was an issue
for you, but if you look at the big version of our logo at the webpage from a
close distance, you can see that the shape of the dropped shadow in the upper
left corner isn't smooth, in fact, it looks like there's some vertical cut out.
There's also a little clipping on the top-right corner of the box. I think
this is caused by slight differences in how inkscape and gimp interpret the
SVG file.
I used gimp because inkscape created badly antialiased images at the lower
resolutions. I think we might be able to address it by using inkscape to
create a large PNG (eg 2048 pixels), and then use GIMP to resize that large
image to smaller bitmaps.
Regards,
Daniel
--
|:
https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|:
https://libvirt.org -o-
https://fstop138.berrange.com :|
|:
https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|