Re: [libvirt] My beefs with the libvirt XML configuration format

On Thu, Dec 10, 2009 at 06:07:13PM +0000, Daniel P. Berrange wrote: > There should be an option to validate the XML input, either by > providing a VIR_DOMAIN_XML_VALIDATE flag with the APIs which > accept XML as input, or by having virsh edit doing validation > after the editor exits. I think I suggested a couple of time to have the input XML data be validated at the API level, but we don't want to do this systematically, this would create IMHO more problems it can solve. Using a flag and/or activating it when libvirt conf is in debug mode would both make sense. > This would also allow virsh to re-launch the editor upon error > and let you correct the mistake instead of forcing you to start > again from scratch. The schemas validation won't be perfect in any way, for example trying to limit the list of allowed ethernet adapter based on the hypervisor type is nearly impossible even with Relax-NG since we differentiate based on an attribute in the top level element (this would force to basically write parallel schemas and become completely unmaintainable). Relax-NG validation also will provide out of context error messages, while the conf parser can give way better diagnostics.