Re: [Libvir] [PATCH] Remote 2.5/8: Export virGetDomain and virGetNetwork
Daniel P. Berrange wrote:
On Sat, May 05, 2007 at 12:00:49PM +0100, Richard W.M. Jones wrote:
> OK so this is step 2.5 out of 8 ... it wasn't part of the original plan.
>
> 2.5 Export virGetDomain and virGetNetwork
> -----------------------------------------
>
> M src/libvirt_sym.version
> M src/hash.c
> M src/internal.h
The virConnectPtr object has these objects cached so it wouldn't
neccessarily be any slower this way. It would have the downside
of slight semantic change - LookupByUUID may actually hit the
undering XenD apis if the cache was empty. This may make for hard
to debug problems & complicate error reporting. So, I think it is
reasonable to export virGetDomain & virGetNetwork to allow direct
use of the cache in this scenario.
Committed to CVS.
Rich.