Re: [libvirt] [PATCH 1/1] qemuxml2xmltest.c: mock /etc/qemu/firmware path
On 8/12/19 5:06 PM, Daniel Henrique Barboza wrote:
Since commit 'b66ca0220a' the 'tpm-emulator' tests in
qemuxml2xmltest
started to fail unless 'make check' is either executed as root
or with an user with access to /etc/qemu/firmware file. This is the
error that happens in a regular 'make check' run with an unprivileged
user:
Thanks for catching this, I had no idea. But I think the commit that
caused the issue is in fact 5b9819eedc7 because that added code that
leads to the error:
virReportSystemErrorFull 1 $ bt
#0 virReportSystemErrorFull at util/virerror.c:1350
#1 0x00007ffff7a786eb in virDirOpenInternal at util/virfile.c:2845
#2 0x00007ffff7a78757 in virDirOpenIfExists at util/virfile.c:2877
#3 0x00005555555f89bf in qemuFirmwareBuildFileList at qemu/qemu_firmware.c:918
#4 0x00005555555f8f1e in qemuFirmwareFetchConfigs at qemu/qemu_firmware.c:1012
#5 0x00005555555f9e8b in qemuFirmwareFetchParsedConfigs at qemu/qemu_firmware.c:1333
#6 0x00005555555fa355 in qemuFirmwareGetSupported at qemu/qemu_firmware.c:1430
#7 0x00005555555c6bcf in virQEMUCapsFillDomainOSCaps at qemu/qemu_capabilities.c:5179
#8 0x00005555555c7c26 in virQEMUCapsFillDomainCaps at qemu/qemu_capabilities.c:5573
#9 0x00005555555ffd5b in virQEMUDriverGetDomainCapabilities at qemu/qemu_conf.c:1432
#10 0x00005555555d8c88 in qemuDomainDeviceDefValidate at qemu/qemu_domain.c:6741
#11 0x00007ffff7b20be2 in virDomainDeviceDefValidate at conf/domain_conf.c:6547
#12 0x00007ffff7b20c51 in virDomainDefValidateDeviceIterator at conf/domain_conf.c:6564
#13 0x00007ffff7b1b6a6 in virDomainDeviceInfoIterateInternal at conf/domain_conf.c:4141
#14 0x00007ffff7b21da6 in virDomainDefValidate at conf/domain_conf.c:6951
#15 0x00007ffff7b54b46 in virDomainDefParseNode at conf/domain_conf.c:21513
#16 0x00007ffff7b54948 in virDomainDefParse at conf/domain_conf.c:21447
#17 0x00007ffff7b549ee in virDomainDefParseFile at conf/domain_conf.c:21473
#18 0x00005555555bcb69 in testCompareDomXML2XMLFiles at testutils.c:1303
#19 0x000055555558ad63 in testXML2XMLInactive at qemuxml2xmltest.c:45
#20 0x00005555555ba29e in virTestRun at testutils.c:174
#21 0x00005555555a4ae2 in mymain at qemuxml2xmltest.c:657
#22 0x00005555555bc362 in virTestMain at testutils.c:1096
#23 0x00005555555b7a4c in main at qemuxml2xmltest.c:1332
I'm changing the commit message accordingly, ACKing and pushing.
Michal