Re: [libvirt] [PATCH v2] virsh: Correctly initialize libvirt
On Mon, May 16, 2011 at 09:05:36 -0600, Eric Blake wrote:
On 05/16/2011 08:59 AM, Jiri Denemark wrote:
> virsh didn't call virInitialize(), which (among other things)
> initializes virLastErr thread local variable. As a result of that, virsh
> could just segfault in virEventRegisterDefaultImpl() since that is the
> first call that touches (resets) virLastErr.
>
> I have no idea what lucky coincidence made this bug visible but I was
> able to reproduce it in 100% cases but only in one specific environment
> which included building in sandbox.
> ---
> src/libvirt.c | 3 +++
> tools/virsh.c | 13 +++++++++----
> 2 files changed, 12 insertions(+), 4 deletions(-)
ACK.
Pushed, thanks.
Jirka