[PATCH 5/7] virhostcpu.c: refactor virHostCPUParseCountLinux()
This function reads the string in sysfspath/cpu/present and
parses it manually to retrieve the number of present CPUs.
virHostCPUGetPresentBitmap() reads and parses the same file,
using a more robust parser via virBitmapParseUnlimited(),
but returns a bitmap. Let's drop all the manual parsing done
here and simply return the size of the resulting bitmap
from virHostCPUGetPresentBitmap().
Given that no more parsing is being done manually in the function,
rename it to virHostCPUCountLinux().
Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>
---
src/util/virhostcpu.c | 30 +++++++-----------------------
1 file changed, 7 insertions(+), 23 deletions(-)
diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
index 3023bca831..615250d05d 100644
--- a/src/util/virhostcpu.c
+++ b/src/util/virhostcpu.c
@@ -856,33 +856,17 @@ virHostCPUGetStatsLinux(FILE *procstat,
}
-/* Determine the number of CPUs (maximum CPU id + 1) from a file containing
- * a list of CPU ids, like the Linux sysfs cpu/present file */
+/* Determine the number of CPUs (maximum CPU id + 1) present in
+ * the host. */
static int
-virHostCPUParseCountLinux(void)
+virHostCPUCountLinux(void)
{
- char *str = NULL;
- char *tmp;
- int ret = -1;
+ g_autoptr(virBitmap) present = virHostCPUGetPresentBitmap();
- if (virFileReadValueString(&str, "%s/cpu/present", SYSFS_SYSTEM_PATH)
< 0)
+ if (!present)
return -1;
- tmp = str;
- do {
- if (virStrToLong_i(tmp, &tmp, 10, &ret) < 0 ||
- !strchr(",-", *tmp)) {
- virReportError(VIR_ERR_NO_SUPPORT,
- _("failed to parse %s"), str);
- ret = -1;
- goto cleanup;
- }
- } while (*tmp++ && *tmp);
- ret++;
-
- cleanup:
- VIR_FREE(str);
- return ret;
+ return virBitmapSize(present);
}
#endif
@@ -1031,7 +1015,7 @@ int
virHostCPUGetCount(void)
{
#if defined(__linux__)
- return virHostCPUParseCountLinux();
+ return virHostCPUCountLinux();
#elif defined(__FreeBSD__) || defined(__APPLE__)
return virHostCPUGetCountAppleFreeBSD();
#else
--
2.26.2