Re: [libvirt] RHBZ 1013045: Crash on xen domain startup
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 10/30/2013 11:37 AM, Eric Blake wrote:
On 10/30/2013 11:38 AM, Jeremy Fitzhardinge wrote:
> libxl: fix dubious cpumask handling in libxlDomainSetVcpuAffinities
>
> Rather than casting the virBitmap pointer to uint8_t* and then using
> the structure contents as a byte array, use the virBitmap API to
> determine
> the bitmap size and test each bit.
Hmm, we already have virBitmapToData for converting from a virBitmap to
a uint8_t; using that would be much faster for populating cpumap than
doing a per-bit iteration over cpumask.
I looked at that, but I couldn't see it being any more efficient given
that we're typically talking about a small number of (v)CPUs.
J
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
iQEkBAEBCgAGBQJScVdcAAoJEAUkni6MUg7HF7IIQLBNIlssnxTx9dAqPSIc9mL+
gNvBzuflYT1QXjggfj49c/MozJJ+rZdCCu5NjAKqpLGYUpYohNg5aG1Vc1uw3OtQ
zyyU1vmF7/kwxLKKcqHpxcpc+miB4NYIVMTYQ+bvIHcpZv8nk+a4freR0/8zVgX1
zQH94kcV8zBn5i03BRuCMO+GCd6AYJRNz++hBadrn/OErE/D8iwcfssasIDl3kFP
lpby15niqiv3BT6bmrg2bMRJ5qKYnhbezhcMilOw6nZ2QOqP2/cZltHv99qwcbns
32uD+FdeTjN6BJ61UP8nAzEy96cvY1YIbc7z1kmr8F2aMPELoHfXPUCkJyUj9YLM
pc+NV9915A==
=MRR8
-----END PGP SIGNATURE-----