Re: [libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP
On Wed, Jul 04, Daniel P. Berrangé wrote:
On Wed, Jul 04, 2018 at 01:48:56PM +0200, Olaf Hering wrote:
> Since bind() already succeeded (or will succeed) for one address, there is
> no reason to error out. Anyone who connects to an resolved ipv6 address will
> get an error, and moves on to try the resolved ipv4 address.
> libvirt is overdoing things here.
Many of the errnos reported by bind() indicate problems we should not be
ignoring IMHO. So I'd rather handle the actual errnos that indicate
non-fatal problems.
So you prefer to keep the existing behavior that all errors from bind()
are fatal, even if nsocks!=0?
What is the reason for that behavior? So far noone was willing to answer that question.
Olaf
Attachments:
- signature.asc (application/pgp-signature — 195 bytes)